[PATCH] D76878: Implement new DW_OP_LLVM_* operations

[Scott Linder via Phabricator via llvm-commits]

scott.linder added a comment.

In D76878#1949376 <https://reviews.llvm.org/D76878#1949376>, @djtodoro wrote:

> In D76878#1946934 <https://reviews.llvm.org/D76878#1946934>, @scott.linder wrote:
>
> > In D76878#1945912 <https://reviews.llvm.org/D76878#1945912>, @djtodoro wrote:
> >
> > > Please add the debug-info project in all the patches.
> > >
> > > I don't see a verifier for these operations, please add that.
> >
> >
> > I'm not sure what verifier you're referring to; is this a part of CodeGen or DebugInfo?
>
>
> The Debug Info.
>  Depending on the intention of using this we should add verifiers for the levels of representation. E.g. if we use it on LLVM IR, we should add a verifier in //lib/IR/Verifier//. The verifier for operation from the final DWARF context is stored within //lib/DebugInfo/DWARF/DWARFVerifier//.
>
> Anyhow, I think that having an RFC would make this easier for the review. :)
>
>     


The diff at https://reviews.llvm.org/D70523 served as the initial RFC, and @t-tye is still working diligently to update it and reformat it in preparation for presenting it to DWARF proper. In the mean time any review of that that section of AMDGPUUsage.rst is welcome. We hope to be able to implement as much as feasible in a compiler (LLVM) and debugger (GDB) in parallel with working to propose it to DWARF as a way to prove an implementation is feasible.

I will look into extending DWARFVerifier further, but this patch does not include any more fundamental changes that would be needed to implement the entire proposal, it implements just enough of it to emit unwind information needed for AMDGPU. I was hoping to review and land this series of patches before starting the remaining work which will involve changes in IR/MIR/DebugInfo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76878/new/

https://reviews.llvm.org/D76878