[PATCH] D76878: Implement new DW_OP_LLVM_* operations

Mon Mar 30 01:35:27 PDT 2020

djtodoro added a comment.

In D76878#1946934 <https://reviews.llvm.org/D76878#1946934>, @scott.linder wrote:

> In D76878#1945912 <https://reviews.llvm.org/D76878#1945912>, @djtodoro wrote:
>
> > Please add the debug-info project in all the patches.
> >
> > I don't see a verifier for these operations, please add that.
>
>
> I'm not sure what verifier you're referring to; is this a part of CodeGen or DebugInfo?

The Debug Info.
Depending on the intention of using this we should add verifiers for the levels of representation. E.g. if we use it on LLVM IR, we should add a verifier in //lib/IR/Verifier//. The verifier for operation from the final DWARF context is stored within //lib/DebugInfo/DWARF/DWARFVerifier//.

Anyhow, I think that having an RFC would make this easier for the review. :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76878/new/

https://reviews.llvm.org/D76878