[PATCH] D77027: Make BitVector::operator== return false for different-sized vectors

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 30 04:50:29 PDT 2020


Meinersbur added a comment.

Since BitVector is supposed to resemble a `std::vector<bool>`, this is the behavior I'd expect.

APInts can be interpreted as either signed or unsigned, making comparison of different lengths undefined.

LGTM, but please wait a bit for other opinions before committing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77027/new/

https://reviews.llvm.org/D77027





More information about the llvm-commits mailing list