[PATCH] D77027: Make BitVector::operator== return false for different-sized vectors

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 30 01:02:41 PDT 2020


nikic added a comment.

I'm wondering whether it would make more sense to make this an assertion instead. Comparing bit vectors of different size doesn't seem like a well-defined operation. (We do assert if you compare APInts of different sizes, for example).

Disclaimer: I don't have any particularly familiarity with this piece of code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77027/new/

https://reviews.llvm.org/D77027





More information about the llvm-commits mailing list