[PATCH] D76829: [lit] Introduce setup and teardown routines

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a subscriber: zturner.
rnk added a comment.

Given the use cases described, I think what you have is probably the best way forward.

However, I'd add that setup steps are not parallelized. Any work that lit does up front slows the test suite down significantly, so in general we should prefer to do any set up with *in* the test, rather than up front. For your use case, the overhead comes from round trip network latency, not CPU time, so up front set up makes sense.

In the past, @zturner wanted to create clean output directories for every test up front, so that `%T` wouldn't be as dangerous. I forget if it landed, but I remember that one version of the patch did a lot of IO up front (deleting all temp files from the last test run), and he had to rework it to do the FS work during test execution.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76829/new/

https://reviews.llvm.org/D76829