[PATCH] D76829: [lit] Introduce setup and teardown routines

Sergej Jaskiewicz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 27 10:55:32 PDT 2020


broadwaylamb added a comment.

In D76829#1946451 <https://reviews.llvm.org/D76829#1946451>, @ldionne wrote:

> FWIW, that's needed for correctness because tests could modify these files. When running locally, we would also need to copy the files to temporary directories, but we don't do it.


If such tests are introduced (those that modify their inputs), we'll just copy their inputs only for them. But there are no such tests now.

> I'm curious to know -- what are you tarring up exactly? We have only a few small inputs, don't we?

Only this directory: `libcxx/test/std/input.output/filesystems/Inputs`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76829/new/

https://reviews.llvm.org/D76829





More information about the llvm-commits mailing list