[PATCH] D75893: [OpenMP] Add !range metadata to loads from omp.(ub/lb)

Kaushik Kulkarni via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 27 11:28:34 PDT 2020


kaushikcfd added inline comments.


================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2739
                 CGF.EmitIgnoredExpr(S.getEnsureUpperBound());
-              // IV = LB;
-              CGF.EmitIgnoredExpr(S.getInit());
               // For unchunked static schedule generate:
               //
----------------
jdoerfert wrote:
> How did this help? There must be test changes in clang, right?
All the loads to %omp.(lb,ub), would now lie in the same BB as `kmpc_for_static_init_4`, fitting our pattern in OpenMPOpt.

>  There must be test changes in clang, right?

Possibly, I should take a look on that front. (If we are looking for an easier pattern to match we would've incurred this problem one way or the other.)




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75893/new/

https://reviews.llvm.org/D75893





More information about the llvm-commits mailing list