[PATCH] D75893: [OpenMP] Add !range metadata to loads from omp.(ub/lb)

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2739
                 CGF.EmitIgnoredExpr(S.getEnsureUpperBound());
-              // IV = LB;
-              CGF.EmitIgnoredExpr(S.getInit());
               // For unchunked static schedule generate:
               //
----------------
How did this help? There must be test changes in clang, right?


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:261
+    }
+  }
+
----------------
Checking via operands of instructions that are skipped doesn't work in general. You could have a bitcast or anything that "hides" the pointer even though it is used. I think we should be more conservative as this is a pattern. Only skip loads and stores and only if the loaded/stored pointer is an alloca different from what what we look at. Everything else is a reason to bail


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75893/new/

https://reviews.llvm.org/D75893