[PATCH] D76285: [X86][MC] Fix the bug for prefix padding support

[Kan Shengchen via Phabricator via llvm-commits]

skan marked 2 inline comments as done.
skan added inline comments.


================
Comment at: llvm/test/MC/X86/align-branch-64-pad-max-prefix.s:1
+  # RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux-gnu --x86-align-branch-boundary=32 --x86-align-branch=jmp -x86-pad-max-prefix-size=5 %s | llvm-objdump -d --no-show-raw-insn - | FileCheck %s
+  # Check instructions can be aligned correctly along with option -x86-pad-max-prefix-size=5
----------------
MaskRay wrote:
> I am late, but the indentation is really not needed.
> 
> `-pc-linux-gnu` is really not needed.
Almost all test cases align-branch* use the indentation , `-pc-linux-gnu` , we can delete them all at once later if necessary.


================
Comment at: llvm/test/MC/X86/align-branch-64-pad-max-prefix.s:14
+# CHECK:      1d:          nop
+# CHECK:      1e:          nop
+# CHECK:      1f:          nop
----------------
MaskRay wrote:
> Add `-CHECK:` if applicable.
sorry, didn't get your point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76285/new/

https://reviews.llvm.org/D76285