[PATCH] D76285: [X86][MC] Fix the bug for prefix padding support
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 26 23:23:24 PDT 2020
MaskRay added inline comments.
================
Comment at: llvm/test/MC/X86/align-branch-64-pad-max-prefix.s:1
+ # RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux-gnu --x86-align-branch-boundary=32 --x86-align-branch=jmp -x86-pad-max-prefix-size=5 %s | llvm-objdump -d --no-show-raw-insn - | FileCheck %s
+ # Check instructions can be aligned correctly along with option -x86-pad-max-prefix-size=5
----------------
I am late, but the indentation is really not needed.
`-pc-linux-gnu` is really not needed.
================
Comment at: llvm/test/MC/X86/align-branch-64-pad-max-prefix.s:14
+# CHECK: 1d: nop
+# CHECK: 1e: nop
+# CHECK: 1f: nop
----------------
Add `-CHECK:` if applicable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76285/new/
https://reviews.llvm.org/D76285
More information about the llvm-commits
mailing list