[PATCH] D76735: [mlir][SPIRV] Update dialect/op documentation to be consistent with the rest of the dialects

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 12:29:34 PDT 2020


antiagainst added a comment.

The first part of description (before `### Custom assembly form`) is automatically populated from the SPIR-V spec by the gen_spirv_dialect.py tool.  The part after `### Custom assembly form` is manually added. So `### Custom assembly form` is the anchor at the moment to split. To remove it means we need rethink how the documentation is done. (The `Example ... mlir` part is fine as Mahesh pointed out.) Can I ask what do we want to achieve here? Will you automatically generate the custom assembly form's doc some way?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76735/new/

https://reviews.llvm.org/D76735





More information about the llvm-commits mailing list