[PATCH] D76735: [mlir][SPIRV] Update dialect/op documentation to be consistent with the rest of the dialects

Thu Mar 26 00:30:40 PDT 2020

mravishankar added a comment.

Actually, strike what I said earlier. The script uses the existing text for an op.

But can you just update these two lines of the script to match what you have here.  https://github.com/llvm/llvm-project/blob/92744f624783d92a07db25bc76e181b879f17e5b/mlir/utils/spirv/gen_spirv_dialect.py#L677 - #L678

Also I think (@antiagainst can confirm), the `### Custom assembly format` is used as a demarcartor by the generator script. I tried to find cases above where it is removed.

================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVLogicalOps.td:825

-    ### Custom assembly form
-
----------------
Please dont remove this. It is used by the dialect generator script as a demarcator

================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVNonUniformOps.td:70

-    ### Custom assembly form
-
----------------
Please dont remove this. It is used by the dialect generator script as a demarcator

================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVNonUniformOps.td:119

-    ### Custom assembly form
-
----------------
Please dont remove this. It is used by the dialect generator script as a demarcator

================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVOps.td:137

-    ### Custom assembly form
-
----------------
Please dont remove this. It is used by the dialect generator script as a demarcator

================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVOps.td:299

-    ### Custom assembly form
-
----------------
Please dont remove this. It is used by the dialect generator script as a demarcator

================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVOps.td:394

-    ### Custom assembly form
-
----------------
Please dont remove this. It is used by the dialect generator script as a demarcator

================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVStructureOps.td:36

-    ### Custom assembly form
-
----------------
Please dont remove this. It is used by the dialect generator script as a demarcator

================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVStructureOps.td:480

-    ### Custom assembly form

----------------
Please dont remove this. It is used by the dialect generator script as a demarcator

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76735/new/

https://reviews.llvm.org/D76735