[PATCH] D76851: [lld][ELF][test] Improve deplib.s

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/deplibs.s:4
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %p/Inputs/deplibs-lib_foo.s -o %tfoo.o
 # RUN: rm -rf %t.dir %t.cwd
----------------
Up to you, but `Inputs/deplibs-lib_foo.s` can also be removed. It is small and thus inlining it helps reading.

`echo '.globl foo; foo:' | llvm-mc -filetype=obj -triple=x86_64 - -o %tfoo.o` (most `-unknown-linux` are not useful)


================
Comment at: lld/test/ELF/deplibs.s:62
+# CWD-NEXT:        {{^foo\.a}}
+# PLAIN-DIR-NEXT:  [[DIR]]{{[\\/]}}foo.a
+# LIBA-DIR-NEXT:   [[DIR]]{{[\\/]}}libfoo.a.a
----------------
One space after `PLAIN-DIR-NEXT:`


================
Comment at: lld/test/ELF/deplibs.s:68
+    .asciz "foo.a"
+    ## Show that an unneeded archive must be present but is not linked in.
+    .asciz "bar"
----------------
is not -> may not be


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76851/new/

https://reviews.llvm.org/D76851