[PATCH] D76851: [lld][ELF][test] Improve deplib.s

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 08:06:16 PDT 2020


jhenderson created this revision.
jhenderson added reviewers: MaskRay, grimar, ruiu, peter.smith.
Herald added a subscriber: emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
jhenderson updated this revision to Diff 252848.
jhenderson added a comment.

Remove unneeded test input.


The test had a few style issues, and I noticed a hole in the coverage (namely that the search order wasn't tested). Adding cases for the hole in turn meant other cases weren't important.

The .so test case isn't important, since the code is shared code, so I've removed it. Additionally, I've modified the usage of the "bar" directive to show that an unneeded library must still be present, or the link will fail, even though it isn't linked in.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76851

Files:
  lld/test/ELF/Inputs/deplibs-lib_bar.s
  lld/test/ELF/deplibs.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76851.252848.patch
Type: text/x-patch
Size: 5364 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200326/633ebe56/attachment-0001.bin>


More information about the llvm-commits mailing list