[PATCH] D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Latest veresion basically looks fine. One suggestion and one question remaining from me.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/RISCV/invalid-attr-section-size.test:6
+
+# CHECK: error: '{{.*}}.o': invalid section size 0 at offset 0x1
+
----------------
If you want to be more precise with your check (I don't think it matters too much, but it might be good), you can use something like `FileCheck -DFILE=%t` and change the pattern here to `error: '[[FILE]].{{64|32]}.o':`.

Same would apply in other tests.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/RISCV/invalid-attr-section-size.test:18
+## Version: 'A'(0x41), section size: 0
+    Content: 4100000000
----------------
Is the size 32-bits even for ELF64?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75833/new/

https://reviews.llvm.org/D75833