[PATCH] D76721: Clarify use of llvm_unreachable in the coding standard

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 12:54:27 PDT 2020


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/docs/CodingStandards.rst:1160
+unconditionally a bug of some kind. Use of ``assert`` should always include a
+testable predicate (as opposed to ``assert(false)``).
+
----------------
Suggestion:
[ ... ] bug<ins> (not originating from user input; see below)</ins> of some kind. [ ... ]

Also, it would help for the patch to include more context.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76721/new/

https://reviews.llvm.org/D76721





More information about the llvm-commits mailing list