[PATCH] D76721: Clarify use of llvm_unreachable in the coding standard

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 12:54:18 PDT 2020


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

ah, good to see there's already some verbiage here that covers the general idea (which I'd clearly forgotten about, might've been good framing for the discussion earlier, so good to know it's here) - specifically saying "here's a better thing" but "use it" is left as an implication - the new paragraph makes that more explicit, which is good.

Thanks a bunch!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76721/new/

https://reviews.llvm.org/D76721





More information about the llvm-commits mailing list