[PATCH] D76401: [PowerPC][AIX] ByVal formal argument support: single register.

[Zarko Todorovski via Phabricator via llvm-commits]

ZarkoCA added a comment.

IMO, the patch is pretty much done, just some test clean up.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7071
+        InVals.push_back(FIN);
+      } else {
+        if (ByValSize > PtrByteSize)
----------------
Is it possible to add a `continue` after line 7070 and then remove the `else`? 


================
Comment at: llvm/test/CodeGen/PowerPC/aix-cc-byval.ll:78
+; 32BIT-NEXT:         isImmutable: false, isAliased: true, callee-saved-register: '', callee-saved-restored: true,
+; 32BIT-NEXT:         debug-info-variable: '', debug-info-expression: '', debug-info-location: '' }
+; 32BIT-NEXT:     - { id: 1, type: default, offset: 24, size: 4, alignment: 8, stack-id: default,
----------------
Maybe you can remove this line.  I think the relevant info for the test is only the lines which show the offset and the size


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76401/new/

https://reviews.llvm.org/D76401