[PATCH] D76637: [mlir][Linalg] Allow tiling of batch dimension for convolution ops with padding.

Han-Chung Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 23 15:48:54 PDT 2020


hanchung requested changes to this revision.
hanchung added a comment.

Add a test?



================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp:351
+        !llvm::all_of(tileSizes.drop_front(),
+                      [](Value val) { return matchPattern(val, m_Zero()); }))
+      return llvm::None;
----------------
Use `isZero(val)`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76637/new/

https://reviews.llvm.org/D76637





More information about the llvm-commits mailing list