[PATCH] D76637: [mlir][Linalg] Allow tiling of batch dimension for convolution ops with padding.

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula requested changes to this revision.
bondhugula added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp:348
+    // For conv op only support tiling along batch dimension (which is the first
+    // loop)
+    if (convOp.padding() &&
----------------
Nit: Missing period at the end.


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp:444
 
+  if (auto convOp = dyn_cast<linalg::ConvOp>(op.getOperation())) {
+    // For conv op only support tiling along batch dimension (which is the first
----------------
You don't need the getOperation(). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76637/new/

https://reviews.llvm.org/D76637