[PATCH] D75931: [PowerPC][Future] Add initial support for PC Relative addressing to get jump table base address

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 23 13:06:36 PDT 2020


nemanjai added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:2856
   if (Subtarget.is64BitELFABI() || Subtarget.isAIXABI()) {
+    if (Subtarget.hasPCRelativeMemops()) {
+      SDLoc DL(JT);
----------------
amyk wrote:
> I think it would be good if we can put a comment above briefly saying what happens when we have PC relative mem ops.
Also, remove this from the AIX block as there is no PC-Rel on AIX.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75931/new/

https://reviews.llvm.org/D75931





More information about the llvm-commits mailing list