[PATCH] D75931: [PowerPC][Future] Add initial support for PC Relative addressing to get jump table base address

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 23 13:06:34 PDT 2020


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM aside from a couple of nits. Feel free to address those on the commit.



================
Comment at: llvm/test/CodeGen/PowerPC/jump-table.ll:13
+; CHECK-NEXT:    rldic r4, r4
+; CHECK-NEXT:    paddi r5, 0, .LJTI0_0 at PCREL, 1
+
----------------
I think it would be useful to show how the base address is used as well. Please add checks for at least all the instructions until the `bctr`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75931/new/

https://reviews.llvm.org/D75931





More information about the llvm-commits mailing list