[llvm] 84fc123 - [DebugInfo][NFCI]: Removed an exclamation mark from error message.

[David Blaikie via llvm-commits]

Probably would've been worth adding {{$}} to the CHECK line when this was
fix was committed to demonstrate the test coverage - but I wouldn't worry
about it at this point/anymore - note for next time, though.

On Sun, Mar 22, 2020 at 9:43 PM Tomar, Sourabh Singh <
SourabhSingh.Tomar at amd.com> wrote:

> [AMD Official Use Only - Internal Distribution Only]
>
>
>
> Hi,
>
> Test case is already present part of parent revision(a71feda24ea092ec144).
> It was just that err message emitted was having (!) mark. While the test
> case doesn’t.
> So I removed that here.
>
>
>
> Test case – present in parent revision
>
> test/tools/llvm-dwp/X86/wrong-unit-type-info-v5.s
>
> Corresponding check-
>
> CHECK: error: {{.*}}: unit type DW_UT_split_compile type not found in
> debug_info header. Unexpected unit type 0x12 found
>
> *From:* David Blaikie <dblaikie at gmail.com>
> *Sent:* Monday, March 23, 2020 9:45 AM
> *To:* Tomar, Sourabh Singh <SourabhSingh.Tomar at amd.com>; Sourabh Singh
> Tomar <llvmlistbot at llvm.org>
> *Cc:* llvm-commits <llvm-commits at lists.llvm.org>
> *Subject:* Re: [llvm] 84fc123 - [DebugInfo][NFCI]: Removed an exclamation
> mark from error message.
>
>
>
> [CAUTION: External Email]
>
> Please add a test for this. (likely an existing test probably covers this
> error message, but it should be updated to test for the specific message)
>
>
>
> On Wed, Feb 19, 2020 at 6:19 PM Sourabh Singh Tomar via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>
> Author: Sourabh Singh Tomar
> Date: 2020-02-20T07:49:08+05:30
> New Revision: 84fc1233d9a47cd7b6e681b4573d9abbc779dd2b
>
> URL:
> https://github.com/llvm/llvm-project/commit/84fc1233d9a47cd7b6e681b4573d9abbc779dd2b
> <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project%2Fcommit%2F84fc1233d9a47cd7b6e681b4573d9abbc779dd2b&data=02%7C01%7CSourabhSingh.Tomar%40amd.com%7Ce459f79879f94a57e55908d7cee0c443%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637205337071413247&sdata=eey9RGnXJCckeTZOwpc1qjZxHIlLsWmdxoh09RSl9A8%3D&reserved=0>
> DIFF:
> https://github.com/llvm/llvm-project/commit/84fc1233d9a47cd7b6e681b4573d9abbc779dd2b.diff
> <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project%2Fcommit%2F84fc1233d9a47cd7b6e681b4573d9abbc779dd2b.diff&data=02%7C01%7CSourabhSingh.Tomar%40amd.com%7Ce459f79879f94a57e55908d7cee0c443%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637205337071413247&sdata=sEjauiWjfSuCpv%2BGPhArrGlOnPgV4mYJvvSNi4Rckyc%3D&reserved=0>
>
> LOG: [DebugInfo][NFCI]: Removed an exclamation mark from error message.
>
> Added:
>
>
> Modified:
>     llvm/tools/llvm-dwp/llvm-dwp.cpp
>
> Removed:
>
>
>
>
> ################################################################################
> diff  --git a/llvm/tools/llvm-dwp/llvm-dwp.cpp
> b/llvm/tools/llvm-dwp/llvm-dwp.cpp
> index f437063d1921..4eff8476d61f 100644
> --- a/llvm/tools/llvm-dwp/llvm-dwp.cpp
> +++ b/llvm/tools/llvm-dwp/llvm-dwp.cpp
> @@ -155,7 +155,7 @@ static Expected<CompileUnitIdentifiers>
> getCUIdentifiers(StringRef Abbrev,
>        return make_error<DWPError>(
>            std::string("unit type DW_UT_split_compile type not found in "
>                        "debug_info header. Unexpected unit type 0x" +
> -                      utostr(UnitType) + " found!"));
> +                      utostr(UnitType) + " found"));
>    }
>    InfoData.getU32(&Offset); // Abbrev offset (should be zero)
>    uint8_t AddrSize = InfoData.getU8(&Offset);
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.llvm.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fllvm-commits&data=02%7C01%7CSourabhSingh.Tomar%40amd.com%7Ce459f79879f94a57e55908d7cee0c443%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637205337071413247&sdata=HUfgDqeCSLODICeRu3hL2xoKnfNn0oZTaKmfXiorvZs%3D&reserved=0>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200322/f8546758/attachment.html>