<div dir="ltr">Probably would've been worth adding {{$}} to the CHECK line when this was fix was committed to demonstrate the test coverage - but I wouldn't worry about it at this point/anymore - note for next time, though.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Mar 22, 2020 at 9:43 PM Tomar, Sourabh Singh <<a href="mailto:SourabhSingh.Tomar@amd.com">SourabhSingh.Tomar@amd.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div class="gmail-m_8945713597564601592WordSection1">
<p class="gmail-m_8945713597564601592msipheader4d0fcdd7" style="margin:0in 0in 0.0001pt"><span style="font-size:10pt;font-family:Arial,sans-serif;color:rgb(0,120,215)">[AMD Official Use Only - Internal Distribution Only]</span><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Hi,<u></u><u></u></p>
<p class="MsoNormal">Test case is already present part of parent revision(a71feda24ea092ec144). It was just that err message emitted was having (!) mark. While the test case doesn’t.
<br>
So I removed that here.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Test case – present in parent revision<u></u><u></u></p>
<p class="MsoNormal">test/tools/llvm-dwp/X86/wrong-unit-type-info-v5.s<u></u><u></u></p>
<p class="MsoNormal">Corresponding check-<u></u><u></u></p>
<p class="MsoNormal">CHECK: error: {{.*}}: unit type DW_UT_split_compile type not found in debug_info header. Unexpected unit type 0x12 found<u></u><u></u></p>
<div>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0in 0in">
<p class="MsoNormal"><b>From:</b> David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> <br>
<b>Sent:</b> Monday, March 23, 2020 9:45 AM<br>
<b>To:</b> Tomar, Sourabh Singh <<a href="mailto:SourabhSingh.Tomar@amd.com" target="_blank">SourabhSingh.Tomar@amd.com</a>>; Sourabh Singh Tomar <<a href="mailto:llvmlistbot@llvm.org" target="_blank">llvmlistbot@llvm.org</a>><br>
<b>Cc:</b> llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>
<b>Subject:</b> Re: [llvm] 84fc123 - [DebugInfo][NFCI]: Removed an exclamation mark from error message.<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">[CAUTION: External Email] <u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">Please add a test for this. (likely an existing test probably covers this error message, but it should be updated to test for the specific message)<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Wed, Feb 19, 2020 at 6:19 PM Sourabh Singh Tomar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt">
<p class="MsoNormal"><br>
Author: Sourabh Singh Tomar<br>
Date: 2020-02-20T07:49:08+05:30<br>
New Revision: 84fc1233d9a47cd7b6e681b4573d9abbc779dd2b<br>
<br>
URL: <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project%2Fcommit%2F84fc1233d9a47cd7b6e681b4573d9abbc779dd2b&data=02%7C01%7CSourabhSingh.Tomar%40amd.com%7Ce459f79879f94a57e55908d7cee0c443%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637205337071413247&sdata=eey9RGnXJCckeTZOwpc1qjZxHIlLsWmdxoh09RSl9A8%3D&reserved=0" target="_blank">
https://github.com/llvm/llvm-project/commit/84fc1233d9a47cd7b6e681b4573d9abbc779dd2b</a><br>
DIFF: <a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project%2Fcommit%2F84fc1233d9a47cd7b6e681b4573d9abbc779dd2b.diff&data=02%7C01%7CSourabhSingh.Tomar%40amd.com%7Ce459f79879f94a57e55908d7cee0c443%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637205337071413247&sdata=sEjauiWjfSuCpv%2BGPhArrGlOnPgV4mYJvvSNi4Rckyc%3D&reserved=0" target="_blank">
https://github.com/llvm/llvm-project/commit/84fc1233d9a47cd7b6e681b4573d9abbc779dd2b.diff</a><br>
<br>
LOG: [DebugInfo][NFCI]: Removed an exclamation mark from error message.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
llvm/tools/llvm-dwp/llvm-dwp.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/llvm/tools/llvm-dwp/llvm-dwp.cpp b/llvm/tools/llvm-dwp/llvm-dwp.cpp<br>
index f437063d1921..4eff8476d61f 100644<br>
--- a/llvm/tools/llvm-dwp/llvm-dwp.cpp<br>
+++ b/llvm/tools/llvm-dwp/llvm-dwp.cpp<br>
@@ -155,7 +155,7 @@ static Expected<CompileUnitIdentifiers> getCUIdentifiers(StringRef Abbrev,<br>
return make_error<DWPError>(<br>
std::string("unit type DW_UT_split_compile type not found in "<br>
"debug_info header. Unexpected unit type 0x" +<br>
- utostr(UnitType) + " found!"));<br>
+ utostr(UnitType) + " found"));<br>
}<br>
InfoData.getU32(&Offset); // Abbrev offset (should be zero)<br>
uint8_t AddrSize = InfoData.getU8(&Offset);<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.llvm.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fllvm-commits&data=02%7C01%7CSourabhSingh.Tomar%40amd.com%7Ce459f79879f94a57e55908d7cee0c443%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637205337071413247&sdata=HUfgDqeCSLODICeRu3hL2xoKnfNn0oZTaKmfXiorvZs%3D&reserved=0" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote></div>