[PATCH] D75671: [llvm-readobj][llvm-readelf][test] - Add a test to check how we dump relocation addends.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of nits.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/reloc-addends.test:13
+# LLVM-RELA64-NEXT: R_X86_64_NONE - 0xFFFFFFFFFFFFCFC7{{$}}
+# LLVM-RELA64-NEXT: R_X86_64_NONE - 0x12345
+
----------------
Missing `{{$}}`?


================
Comment at: llvm/test/tools/llvm-readobj/ELF/reloc-addends.test:17
+##        See https://bugs.llvm.org/show_bug.cgi?id=45235.
+
+# GNU-RELA64:      Type          Symbol's Value  Symbol's Name + Addend
----------------
I'd probably delete this blank line, to show that this is tied to the GNU block (mostly for consistency with my comment in the next section).


================
Comment at: llvm/test/tools/llvm-readobj/ELF/reloc-addends.test:35-37
+## FIXME: We either should not dump an addend or should read it from a
+##        destination location for a SHT_REL case.
+##        See https://bugs.llvm.org/show_bug.cgi?id=44257.
----------------
The FIXME is tied to the LLVM case, right? If so, delete the blank line after it. At the moment, it looks like it applies to both cases.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/reloc-addends.test:96
+## FIXME: GNU readelf prints addends differently.
+##        See https://bugs.llvm.org/show_bug.cgi?id=45235.
+
----------------
Same comment as above re. the blank line after this FIXME.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/reloc-addends.test:116
+##        destination location for a SHT_REL case.
+##        See https://bugs.llvm.org/show_bug.cgi?id=44257.
+
----------------
Same comment as above re. this FIXME.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75671/new/

https://reviews.llvm.org/D75671