[PATCH] D75671: [llvm-readobj][llvm-readelf][test] - Add a test to check how we dump relocation addends.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 18 05:24:38 PDT 2020
grimar marked an inline comment as done.
grimar added inline comments.
================
Comment at: llvm/test/tools/llvm-readobj/ELF/reloc-addends.test:82
+ Type: R_X86_64_NONE
+## Addend == an arbitrary negative number.
+ - Addend: 0xFFFFFFFFFFFFCFC7 ## -12345
----------------
grimar wrote:
> jhenderson wrote:
> > Any particular reason you have an arbitrary negative number, but not an arbitrary positive one?
> Nope. I just do not like the negative numbers representation I think, my brain assumes them are "special".
> I.e added the arbitrary positive number case.
I.e -> I've
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75671/new/
https://reviews.llvm.org/D75671
More information about the llvm-commits
mailing list