[PATCH] D76398: [X86] Limit prefix padding w/target specific padding amount

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 21:22:59 PDT 2020


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:820
+/// encountering decoder delays for the given target.  Note that the result is
+/// inclusive of escape bytes and manditory prefixes.
+static unsigned maximumPrefixPadding(const MCSubtargetInfo &STI) {
----------------
manditory->mandatory


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:846
+    // TODO: This should probably be '3' once we validate that escape sequences
+    // are conservatively handled.
+    return 0;
----------------
What does conservatively handled mean here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76398/new/

https://reviews.llvm.org/D76398





More information about the llvm-commits mailing list