[PATCH] D76398: [X86] Limit prefix padding w/target specific padding amount

LuoYuanke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 19 20:50:53 PDT 2020


LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:844
+  // prefxes, this seems like a reasonable proxy. 
+  if (STI.getFeatureBits()[X86::FeatureFast7ByteNOP])
+    // TODO: This should probably be '3' once we validate that escape sequences
----------------
I'm not sure the long nop feature can determine the prefix size. I'd leave it to Craig. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76398/new/

https://reviews.llvm.org/D76398





More information about the llvm-commits mailing list