[llvm] b1c8a37 - [llvm-dwp] Start error messages with a lowercase letter.

[Igor Kudrin via llvm-commits]

Author: Igor Kudrin
Date: 2020-03-19T19:43:08+07:00
New Revision: b1c8a378f78befd0f90bbbf70325e66c5f6bc0b6

URL: https://github.com/llvm/llvm-project/commit/b1c8a378f78befd0f90bbbf70325e66c5f6bc0b6
DIFF: https://github.com/llvm/llvm-project/commit/b1c8a378f78befd0f90bbbf70325e66c5f6bc0b6.diff

LOG: [llvm-dwp] Start error messages with a lowercase letter.

We usually start error messages with lowercase letters and most of them
in llvm-dwp follow that rule. This patch fixes a few messages that
started with capital letters.

Differential revision: https://reviews.llvm.org/D76277

Added: 
    

Modified: 
    llvm/test/tools/llvm-dwp/X86/duplicate.test
    llvm/test/tools/llvm-dwp/X86/gcc_type.test
    llvm/test/tools/llvm-dwp/X86/invalid_cu_index.test
    llvm/test/tools/llvm-dwp/X86/missing_tu_index.test
    llvm/tools/llvm-dwp/llvm-dwp.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/llvm-dwp/X86/duplicate.test b/llvm/test/tools/llvm-dwp/X86/duplicate.test
index 43266a24b601..de5f1fdd4231 100644
--- a/llvm/test/tools/llvm-dwp/X86/duplicate.test
+++ b/llvm/test/tools/llvm-dwp/X86/duplicate.test
@@ -18,10 +18,10 @@ RUN:   | FileCheck --check-prefix=DWO1DWP %s
 
 Build from a, b, and c.c all containing a single void() func by the name of the file.
 
-DWOS: error: Duplicate DWO ID ({{.*}}) in 'c.c' and 'c.c'{{$}}
-1DWP: error: Duplicate DWO ID ({{.*}}) in 'c.c' (from '{{.*}}ac.dwp') and 'c.c'{{$}}
-2DWP: error: Duplicate DWO ID ({{.*}}) in 'c.c' and 'c.c' (from '{{.*}}bc.dwp'){{$}}
+DWOS: error: duplicate DWO ID ({{.*}}) in 'c.c' and 'c.c'{{$}}
+1DWP: error: duplicate DWO ID ({{.*}}) in 'c.c' (from '{{.*}}ac.dwp') and 'c.c'{{$}}
+2DWP: error: duplicate DWO ID ({{.*}}) in 'c.c' and 'c.c' (from '{{.*}}bc.dwp'){{$}}
 
-DWODWOS: error: Duplicate DWO ID ({{.*}}) in 'c.c' and 'c.c'{{$}}
-DWO1DWP: error: Duplicate DWO ID ({{.*}}) in 'c.c' (from 'c.dwo' in '{{.*}}ac.dwp') and 'c.c'{{$}}
-DWO2DWP: error: Duplicate DWO ID ({{.*}}) in 'c.c' and 'c.c' (from 'c.dwo' in '{{.*}}bc.dwp'){{$}}
+DWODWOS: error: duplicate DWO ID ({{.*}}) in 'c.c' and 'c.c'{{$}}
+DWO1DWP: error: duplicate DWO ID ({{.*}}) in 'c.c' (from 'c.dwo' in '{{.*}}ac.dwp') and 'c.c'{{$}}
+DWO2DWP: error: duplicate DWO ID ({{.*}}) in 'c.c' and 'c.c' (from 'c.dwo' in '{{.*}}bc.dwp'){{$}}

diff  --git a/llvm/test/tools/llvm-dwp/X86/gcc_type.test b/llvm/test/tools/llvm-dwp/X86/gcc_type.test
index 7bb1a64cd2df..eb8f2ba9fd37 100644
--- a/llvm/test/tools/llvm-dwp/X86/gcc_type.test
+++ b/llvm/test/tools/llvm-dwp/X86/gcc_type.test
@@ -5,4 +5,4 @@ CHECK: Type Unit
 CHECK: Type Unit
 
 // Check that llvm-dwp can parse DW_FORM_string for CU name
-DUP: Duplicate DWO ID ({{.*}}) in 'a.cpp' and 'a.cpp'
+DUP: duplicate DWO ID ({{.*}}) in 'a.cpp' and 'a.cpp'

diff  --git a/llvm/test/tools/llvm-dwp/X86/invalid_cu_index.test b/llvm/test/tools/llvm-dwp/X86/invalid_cu_index.test
index 6fc96b2a1a30..92c9a12cb91e 100644
--- a/llvm/test/tools/llvm-dwp/X86/invalid_cu_index.test
+++ b/llvm/test/tools/llvm-dwp/X86/invalid_cu_index.test
@@ -1,3 +1,3 @@
 RUN: not llvm-dwp %p/../Inputs/invalid_cu_index/x.dwp -o %t 2>&1 | FileCheck %s
 
-CHECK: error: Failed to parse cu_index
+CHECK: error: failed to parse cu_index

diff  --git a/llvm/test/tools/llvm-dwp/X86/missing_tu_index.test b/llvm/test/tools/llvm-dwp/X86/missing_tu_index.test
index 99f5253e8b32..b84ed7c0765c 100644
--- a/llvm/test/tools/llvm-dwp/X86/missing_tu_index.test
+++ b/llvm/test/tools/llvm-dwp/X86/missing_tu_index.test
@@ -1,3 +1,3 @@
 RUN: not llvm-dwp %p/../Inputs/missing_tu_index/x.dwp -o %t 2>&1 | FileCheck %s
 
-CHECK: error: Failed to parse tu_index
+CHECK: error: failed to parse tu_index

diff  --git a/llvm/tools/llvm-dwp/llvm-dwp.cpp b/llvm/tools/llvm-dwp/llvm-dwp.cpp
index df524ad0a2e8..51b3470afee4 100644
--- a/llvm/tools/llvm-dwp/llvm-dwp.cpp
+++ b/llvm/tools/llvm-dwp/llvm-dwp.cpp
@@ -479,7 +479,7 @@ static Error
 buildDuplicateError(const std::pair<uint64_t, UnitIndexEntry> &PrevE,
                     const CompileUnitIdentifiers &ID, StringRef DWPName) {
   return make_error<DWPError>(
-      std::string("Duplicate DWO ID (") + utohexstr(PrevE.first) + ") in " +
+      std::string("duplicate DWO ID (") + utohexstr(PrevE.first) + ") in " +
       buildDWODescription(PrevE.second.Name, PrevE.second.DWPName,
                           PrevE.second.DWOName) +
       " and " + buildDWODescription(ID.Name, DWPName, ID.DWOName));
@@ -596,7 +596,7 @@ static Error write(MCStreamer &Out, ArrayRef<std::string> Inputs) {
     DWARFUnitIndex CUIndex(DW_SECT_INFO);
     DataExtractor CUIndexData(CurCUIndexSection, Obj.isLittleEndian(), 0);
     if (!CUIndex.parse(CUIndexData))
-      return make_error<DWPError>("Failed to parse cu_index");
+      return make_error<DWPError>("failed to parse cu_index");
 
     for (const DWARFUnitIndex::Entry &E : CUIndex.getRows()) {
       auto *I = E.getOffsets();
@@ -631,7 +631,7 @@ static Error write(MCStreamer &Out, ArrayRef<std::string> Inputs) {
       DWARFUnitIndex TUIndex(DW_SECT_TYPES);
       DataExtractor TUIndexData(CurTUIndexSection, Obj.isLittleEndian(), 0);
       if (!TUIndex.parse(TUIndexData))
-        return make_error<DWPError>("Failed to parse tu_index");
+        return make_error<DWPError>("failed to parse tu_index");
       addAllTypesFromDWP(Out, TypeIndexEntries, TUIndex, TypesSection,
                          CurTypesSection.front(), CurEntry,
                          ContributionOffsets[DW_SECT_TYPES - DW_SECT_INFO]);