[PATCH] D75388: Expand interleaved memory access pass to identify certain shuffle_vector and transform it into target specific intrinsics.

Wed Mar 18 14:40:58 PDT 2020

wxz2020 added a comment.

Sanjay Patel :The title of this patch confused me. This is not adding a pass; it is extending existing passes.
WZ:  Agree. It is not a new LLVM pass. The work is piggy backed on an existing pass.  I will change the title.

Sanjay Patel: I did not see an answer to @dmgreen's questions - maybe the biggest one: why is this transform not done entirely in SelectionDAG?
WZ: The answer is in the above comment.

And why would we want AArch-specific "tbl1" pattern-matching in the generic VectorUtils.h?
WZ; Good point! This is an AArch64 specific optimization. The mask is based on AArch64's Tbl1 instruction mask definition. So it should be in a target specific place. I will work out a fix and upload it.

Thanks!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75388/new/

https://reviews.llvm.org/D75388