[PATCH] D76328: [ELF] Allow uppercase section directives

Wed Mar 18 09:14:41 PDT 2020

MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

I am mostly with the following opinions.

http://lists.llvm.org/pipermail/llvm-dev/2020-February/138955.html `@JonChesterfield`: This doesn't sound right. GNU binutils have a large quantity of legacy cruft, not least the redundancy between tools like readelf and objdump which are capable of doing the same task in exchange for different command line arguments.

`@joerg`: So given that we got around with this for years, how much use do non-lower case assembler pseudops actually see?

Can't the projects using uppercase directives be fixed?

> I don't see any obvious reason why they shouldn't be allowed.

Most people agree this is legacy cruft. There is few if any project which must use this syntax. I think we need a very strong reason to support uppercase directives, rather than the converse.

(https://bugs.llvm.org/show_bug.cgi?id=39527 was really a bad example. The author committed one change, despite the request both on the differential and on the bugzilla, they continued making another change with no explanation (bugzilla,differential,or git commit description).)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76328/new/

https://reviews.llvm.org/D76328