[PATCH] D75382: [lld] Initial commit for new Mach-O backend

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 18 07:36:21 PDT 2020


int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:109
+      error("Alignment " + std::to_string(sec.align) + " of section " +
+            isec->name + " is too large");
+    else
----------------
ruiu wrote:
> Set a dummy value (e.g. 1) to `isec->align` if the input is invalid, so that even after we meet an error condition, all the member variables are at least initialized with some value instead of left uninitialized.
`align` is default-initialized to zero in the class definition


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75382/new/

https://reviews.llvm.org/D75382





More information about the llvm-commits mailing list