[PATCH] D75382: [lld] Initial commit for new Mach-O backend
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 18 03:14:01 PDT 2020
ruiu accepted this revision.
ruiu added a comment.
LGTM
================
Comment at: lld/MachO/InputFiles.cpp:108
+ if (sec.align >= 32)
+ error("Alignment " + std::to_string(sec.align) + " of section " +
+ isec->name + " is too large");
----------------
nit: error messages should start with a lowercase letter.
================
Comment at: lld/MachO/InputFiles.cpp:109
+ error("Alignment " + std::to_string(sec.align) + " of section " +
+ isec->name + " is too large");
+ else
----------------
Set a dummy value (e.g. 1) to `isec->align` if the input is invalid, so that even after we meet an error condition, all the member variables are at least initialized with some value instead of left uninitialized.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75382/new/
https://reviews.llvm.org/D75382
More information about the llvm-commits
mailing list