[PATCH] D68065: Propeller: LLD Support for Basic Block Sections

Sriraman Tallam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 16:13:59 PDT 2020


tmsriram added a comment.

In D68065#1927117 <https://reviews.llvm.org/D68065#1927117>, @echristo wrote:

> In general I think a lot of this looks pretty good. It could use some more comments - in particular to call out what a lot of this code is used for. It's not used on a typical linking path and so could be confusing to people going through the code.
>
> -eric


I have added more comments and mentioned that this is only applicable with basic block sections.  I have also added "TODO:" in places where the code is going to get a lot simpler with newer relocations


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68065/new/

https://reviews.llvm.org/D68065





More information about the llvm-commits mailing list