[PATCH] D68065: Propeller: LLD Support for Basic Block Sections

[Eric Christopher via Phabricator via llvm-commits]

echristo added a comment.

In general I think a lot of this looks pretty good. It could use some more comments - in particular to call out what a lot of this code is used for. It's not used on a typical linking path and so could be confusing to people going through the code.

-eric



================
Comment at: lld/ELF/OutputSections.cpp:249
+  std::vector<std::vector<uint8_t>> nopFiller = *target->nopInstrs;
+  unsigned num = size / nopFiller.back().size();
+  for (unsigned c = 0; c < num; ++c) {
----------------
Might want to assert size != 0 or early return.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68065/new/

https://reviews.llvm.org/D68065