[PATCH] D76047: [MLIR] Add support for out of tree external projects using MLIR
Stephen Neuendorffer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 17 14:35:27 PDT 2020
stephenneuendorffer marked an inline comment as done.
stephenneuendorffer added inline comments.
================
Comment at: mlir/cmake/modules/CMakeLists.txt:67
set(MLIR_CONFIG_CMAKE_DIR)
set(MLIR_CONFIG_EXPORTS_FILE)
----------------
marbre wrote:
> Outdated due to the updated definition in line 57?
It appears that the intention here is to unset the corresponding variables which are used to pass information into the configure_file call. There is an error which is that not all of the *CONFIG* variables are unset.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76047/new/
https://reviews.llvm.org/D76047
More information about the llvm-commits
mailing list