[PATCH] D76047: [MLIR] Add support for out of tree external projects using MLIR

[Marius Brehler via Phabricator via llvm-commits]

marbre added inline comments.


================
Comment at: mlir/cmake/modules/CMakeLists.txt:40
+  FILES_MATCHING PATTERN *.cmake
+  PATTERN .svn EXCLUDE
+  PATTERN CMakeFiles EXCLUDE
----------------
Seems like this line might be a leftover from the pre-git times. Can it be dropped?


================
Comment at: mlir/cmake/modules/CMakeLists.txt:67
 set(MLIR_CONFIG_CMAKE_DIR)
 set(MLIR_CONFIG_EXPORTS_FILE)
 
----------------
Outdated due to the updated definition in line 57?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76047/new/

https://reviews.llvm.org/D76047