[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX updated this revision to Diff 250862.
SouraVX added a comment.

Refactored to remove code duplication.

Hi @jhenderson, @Ikudrin, @dblaikie , I've refactored the dumping code to use a single `getDWARFDebugMacro` function for all dumping related to macro/macinfo. Thus removing all three redundant dumping functions `getDebugMacro/Macinfo/MacinfoDWO` . Resultant code looks cleaner/uniform.
@jhenderson I've briefly tried to work on https://reviews.llvm.org/D73086#1921509, hitting up multiple issues, Since this is not just macro/macinfo, a whole lot of sections are represented as `DWARFSection` and `StringRef`. This invites a huge rework.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFObject.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp
  llvm/test/DebugInfo/X86/debug-macro-macinfo.s
  llvm/test/DebugInfo/X86/debug-macro-v5.s
  llvm/test/DebugInfo/X86/unsupported-dwarf64-debug-macro-v5.s
  llvm/test/DebugInfo/X86/unsupported-opcode_operands_table-debug-macro-v5.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73086.250862.patch
Type: text/x-patch
Size: 24059 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200317/6abf9c8b/attachment.bin>