[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 17 07:25:17 PDT 2020


jhenderson added a comment.

In D73086#1926382 <https://reviews.llvm.org/D73086#1926382>, @SouraVX wrote:

> > You said you'd take a look at removing the duplication. Have you done that yet? That's what I'm waiting on.
>
> Oh, Sorry! I think I mentioned that should be taken separately. https://reviews.llvm.org/D73086#1921509


If you want to do it separately, please do it before this patch. This patch makes the situation worse, which is obviously bad.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086





More information about the llvm-commits mailing list