[PATCH] D76207: [PowerPC] implement target hook isProfitableToHoist

Mon Mar 16 20:44:38 PDT 2020

shchenz marked 2 inline comments as done.
shchenz added a comment.

Thanks for your quick review @nemanjai

================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:15271
+                                                   Type *Ty) const {
+  switch (Ty->getScalarType()->getTypeID()) {
+  case Type::FloatTyID:
----------------
nemanjai wrote:
> Can we please not have the same logic in two places. Please either call this one from the other by using `VT.getTypeForEVT()` and `MF.getFunction()`
> or write a separate helper function that can be called by both.
Split out this function as NFC patch in D76265.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76207/new/

https://reviews.llvm.org/D76207