[PATCH] D76207: [PowerPC] implement target hook isProfitableToHoist

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai requested changes to this revision.
nemanjai added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:15271
+                                                   Type *Ty) const {
+  switch (Ty->getScalarType()->getTypeID()) {
+  case Type::FloatTyID:
----------------
Can we please not have the same logic in two places. Please either call this one from the other by using `VT.getTypeForEVT()` and `MF.getFunction()`
or write a separate helper function that can be called by both.


================
Comment at: llvm/test/Transforms/SimplifyCFG/PowerPC/prefer-fma.ll:4
+
+; This case is copied from test/Transforms/SimplifyCFG/AArch64/
+; Function Attrs: nounwind
----------------
I think it would be preferable to pre-commit this test case with full checks produced by the script and then just show the differences here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76207/new/

https://reviews.llvm.org/D76207