[PATCH] D76245: [mlir][spirv] Change standard op patterns to consider type conversion

Mahesh Ravishankar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 13:40:20 PDT 2020


mravishankar accepted this revision.
mravishankar added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRV.cpp:40
 
+// Note that DRR cannot be used for the patterns in this file: we may need to
+// convert type along the way, which requires ConversionPattern. DRR generates
----------------
Thats a shame :( 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76245/new/

https://reviews.llvm.org/D76245





More information about the llvm-commits mailing list