[PATCH] D76245: [mlir][spirv] Change standard op patterns to consider type conversion

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 12:01:31 PDT 2020


antiagainst created this revision.
antiagainst added a reviewer: denis13.
Herald added subscribers: llvm-commits, bader, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: mravishankar.
Herald added a project: LLVM.
antiagainst added a child revision: D76246: [mlir][spirv] Consolidate std.constant to spv.constant conversions.

Previously we have a few patterns that were written with DRR. DRR
at the moment does not work nicely with dialect conversion framework.
It generates normal RewritePatterns, while the dialect conversion
framework requires ConversionPatterns to take into consideration
the type conversion. So this commit starts to change existing DRR
patterns for standard ops to OpConversionPattern to incorporate the
SPIR-V type conversion. All patterns are converted except the one
for constant ops, which will happen in a subsequent commit.

Depends On D76244 <https://reviews.llvm.org/D76244>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76245

Files:
  mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRV.cpp
  mlir/lib/Conversion/StandardToSPIRV/StandardToSPIRV.td
  mlir/test/Conversion/StandardToSPIRV/std-to-spirv.mlir
  mlir/test/Conversion/StandardToSPIRV/std-types-to-spirv.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76245.250609.patch
Type: text/x-patch
Size: 35229 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200316/204860f0/attachment.bin>


More information about the llvm-commits mailing list