[PATCH] D75876: [mlir][spirv] Let SPIRVConversionTarget consider type availability

[Mahesh Ravishankar via Phabricator via llvm-commits]

mravishankar added inline comments.


================
Comment at: mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp:412
 std::unique_ptr<spirv::SPIRVConversionTarget>
 spirv::SPIRVConversionTarget::get(spirv::TargetEnvAttr targetEnv,
                                   MLIRContext *context) {
----------------
mravishankar wrote:
> Could we add a method that sets some targetEnv by default (the one that are used in the tests here for example). 
Just to add to this. Then we can remove the "lookupTargetEnvOrDefault" method right? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75876/new/

https://reviews.llvm.org/D75876