[PATCH] D75876: [mlir][spirv] Let SPIRVConversionTarget consider type availability

Mahesh Ravishankar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 12:35:03 PDT 2020


mravishankar requested changes to this revision.
mravishankar added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp:412
 std::unique_ptr<spirv::SPIRVConversionTarget>
 spirv::SPIRVConversionTarget::get(spirv::TargetEnvAttr targetEnv,
                                   MLIRContext *context) {
----------------
Could we add a method that sets some targetEnv by default (the one that are used in the tests here for example). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75876/new/

https://reviews.llvm.org/D75876





More information about the llvm-commits mailing list