[PATCH] D76161: NFC - Moved AffineOps IR / Transforms

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 12:01:30 PDT 2020


rriddle accepted this revision.
rriddle marked an inline comment as done.
rriddle added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Affine/EDSC/Intrinsics.h:8
 //===----------------------------------------------------------------------===//
 #ifndef MLIR_DIALECT_AFFINEOPS_EDSC_INTRINSICS_H_
 #define MLIR_DIALECT_AFFINEOPS_EDSC_INTRINSICS_H_
----------------
Can you update each of these header guard comments now?


================
Comment at: mlir/include/mlir/Dialect/Affine/Passes.h:9
+//
+// This header file defines a set of transforms specific for the AffineOps
+// dialect.
----------------
AffineOps -> Affine


================
Comment at: mlir/include/mlir/InitAllPasses.h:28
+#include "mlir/Dialect/AffineOps/Passes.h"
+#include "mlir/Dialect/FxpMathOps/Passes.h"
 #include "mlir/Dialect/FxpMathOps/Passes.h"
----------------
rsuderman wrote:
> rriddle wrote:
> > Duplicate?
> I don't see a duplicate? AffineOps/Passes.h was newly added in this CL.
It was previously showing `+ #include "mlir/Dialect/FxpMathOps/Passes.h"`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76161/new/

https://reviews.llvm.org/D76161





More information about the llvm-commits mailing list