[PATCH] D76161: NFC - Moved AffineOps IR / Transforms

Mon Mar 16 11:27:40 PDT 2020

rsuderman marked an inline comment as done and an inline comment as not done.
rsuderman added a comment.

Should be updated for comments.

================
Comment at: mlir/include/mlir/InitAllPasses.h:28
+#include "mlir/Dialect/AffineOps/Passes.h"
+#include "mlir/Dialect/FxpMathOps/Passes.h"
 #include "mlir/Dialect/FxpMathOps/Passes.h"
----------------
rriddle wrote:
> Duplicate?
I don't see a duplicate? AffineOps/Passes.h was newly added in this CL.

================
Comment at: mlir/test/lib/Transforms/TestVectorizationUtils.cpp:16
 #include "mlir/Analysis/SliceAnalysis.h"
-#include "mlir/Dialect/AffineOps/AffineOps.h"
+#include "mlir/Dialect/AffineOps/IR/AffineOps.h"
 #include "mlir/Dialect/VectorOps/VectorUtils.h"
----------------
mehdi_amini wrote:
> Since you had to change all of them, and since every downstream user will have to adjust, what about also renaming the mlir/Dialect/AffineOps into mlir/Dialect/Affine ?
Moved AffineOps to Affine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76161/new/

https://reviews.llvm.org/D76161