[PATCH] D76174: [ELF] Support linking ET_EXEC

Sun Mar 15 19:20:47 PDT 2020

MaskRay abandoned this revision.
MaskRay added a comment.

In D76174#1923326 <https://reviews.llvm.org/D76174#1923326>, @psmith wrote:

> I can see that this would work if the user were very careful and as it is a legitimate use case we should support it. In a previous linker we were asked to make this case an error as a customer had done this by mistake and spent several hours wondering why their program wasn't working. On balance I think it isn't worth a warning along the lines of "warning: file X is an executable" as I don't think that this happens much in practice, but something to think about if other users have problems.
>
> Looks good to me.

Thanks for the feedback. On second thought, I think I shall abandon the patch. This is easy to workaround on seabios' side

https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/thread/HHIUPUXRIZ3KLTK4TPLG2V4PFP32HRBE/

If seabios accepts my 3 patches, they can link seabios with lld 7. Projects like FreeBSD 12 (lld 8.0.1) can immediately benefit from it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76174/new/

https://reviews.llvm.org/D76174