[PATCH] D76174: [ELF] Support linking ET_EXEC

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 15 03:43:34 PDT 2020


psmith added a comment.

I can see that this would work if the user were very careful and as it is a legitimate use case we should support it. In a previous linker we were asked to make this case an error as a customer had done this by mistake and spent several hours wondering why their program wasn't working. On balance I think it isn't worth a warning along the lines of "warning: file X is an executable" as I don't think that this happens much in practice, but something to think about if other users have problems.

Looks good to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76174/new/

https://reviews.llvm.org/D76174





More information about the llvm-commits mailing list