[PATCH] D76200: [VPlan] Use underlying value for printing, if available.
Ayal Zaks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 15 13:55:37 PDT 2020
Ayal added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:588
}
for (auto Entry : Plan.Value2VPValue) {
OS << "\\n";
----------------
If now every VPValue that wraps a Value clearly says so in its name, does it hopefully make this "%vpA := %irX" part of "where:" redundant?
================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:818
+ const Value *UV = getUnderlyingValue();
+ if (UV && UV->hasName()) {
+ OS << "%vp." << UV->getName();
----------------
Even if UV does not have a name, could we still indicate that VPValue wraps it; possibly by calling UV->printAsOperand()?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76200/new/
https://reviews.llvm.org/D76200
More information about the llvm-commits
mailing list